Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range selection support to Datepicker with month view #4941

Closed
fanste opened this issue Jun 26, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@fanste
Copy link
Contributor

commented Jun 26, 2019

1) Environment

2) Expected behavior

A range of months should be selectable.

3) Actual behavior

The datepicker closes when a the start of the range was selected.

4) Steps to reproduce

  • click in input field to open datepicker
  • select first month => popup closes
  • reopen datepicker
  • end of range could be selected

5) Sample XHTML

<h:form id="frmMain">
    <p:datePicker view="month" selectionMode="range"  />
</h:form>

6) Sample bean

Not needed

@fanste

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

JS throws an error if you additionally enable inline mode

TypeError: this.value.getMonth is not a function

In method isMonthSelected

@tandraschko tandraschko added the defect label Jun 28, 2019

@tandraschko

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@mertsincan can you check this? AFAIR you need to sync sources

@mertsincan mertsincan removed the defect label Jul 9, 2019

@mertsincan mertsincan changed the title DatePicker: Month-picker with range not working correctly Add range selection support to Datepicker with month view Jul 9, 2019

@mertsincan mertsincan added this to the 7.1 milestone Jul 9, 2019

@mertsincan mertsincan closed this in 258381d Jul 9, 2019

@mertsincan

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.