Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: annoying min-width #4954

Closed
morvael opened this issue Jul 1, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@morvael
Copy link

commented Jul 1, 2019

1) Environment

  • PrimeFaces version: 7.0.4
  • Application server + version: WildFly 16.0.0
  • Affected browsers: all

2) Expected behavior

DatePicker's text input is as flexible as text inputs from other components.

3) Actual behavior

DatePicker's text input is forced to have a min-width of 17em by '.p-datepicker' class (components.css.xhtml line 5973). This is way too long for date only (or year-month only) patterns.

4) Steps to reproduce

Use DatePicker :)

@morvael

This comment has been minimized.

Copy link
Author

commented Jul 1, 2019

I think it's a defect - other input components are not enforcing their width in such brute force way.

@melloware

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@morvael What happens if you remove that 17em? Does the component look and work fine?

@morvael

This comment has been minimized.

Copy link
Author

commented Jul 1, 2019

Yes, I did just that and it worked fine. Input was narrower than picker panel, as it should be. Someone wanted to make input just as wide as picker panel. Maybe makes sense in inline mode, with popup not so much.

@melloware

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

I agree min-width should not be defined. PR submitted.

@mertsincan mertsincan closed this in c7ca2a9 Jul 9, 2019

mertsincan added a commit that referenced this issue Jul 9, 2019

Merge pull request #4957 from melloware/PF4954
Fix #4954: Remove min-width from DatePicker.

@mertsincan mertsincan added this to the 7.1 milestone Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.