Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p:dataTable: p:rowExpansion doesn't work with p:columnToggler #5211

Closed
Dasister opened this issue Oct 3, 2019 · 3 comments
Closed

p:dataTable: p:rowExpansion doesn't work with p:columnToggler #5211

Dasister opened this issue Oct 3, 2019 · 3 comments
Labels
Milestone

Comments

@Dasister
Copy link

@Dasister Dasister commented Oct 3, 2019

IMPORTANT

  • !!! If you open an issue, fill every item. Otherwise the issue might be closed as invalid. !!!

  • Please use the naming convention for the title:
    ${component}: ${title}
    Example:
    SelectOneMenu: Converter not called

  • Before you open an issue, test it with the current/newest version.

  • Try to find an explanation to your problem by yourself, by simply debugging. This will help us to solve your issue 10x faster

  • Clone this repository https://github.com/primefaces/primefaces-test.git in order to reproduce your problem, you'll have better chance to receive an answer and a solution.

  • Otherwise the example must be as small and simple as possible! It must be runnable without any other dependencies (like Spring,..., or project/company internal classes)!

  • Feel free to provide a PR (PrimeFaces is an open-source project, any fixes or improvements are welcome.)

1) Environment

2) Expected behavior

Colspan of expanded row is equal to number of visible columns in dataTable

3) Actual behavior

Colspan is not equal to visible number of columns. It leads to this:
hidden-cols

4) Steps to reproduce

  1. Open test page
  2. Hide some columns with Column Toggler
  3. Expand row

Sample project: pf-rowexpansion.zip

@melloware melloware added the defect label Oct 3, 2019
@melloware melloware added this to the 8.0 milestone Nov 19, 2019
@fanste

This comment has been minimized.

Copy link
Contributor

@fanste fanste commented Nov 19, 2019

The PR #5349 fixes even some more issues regarding p:columnToggler and p:dataTable.

I once quickly clicked through using the provided sample project.
@Dasister please test my changes.

mertsincan added a commit that referenced this issue Nov 22, 2019
Fix #5211: Datatable rowExpansion and columnToggler
@mertsincan mertsincan added the 7.0.10 label Nov 22, 2019
mertsincan added a commit that referenced this issue Nov 22, 2019
@fmarangon

This comment has been minimized.

Copy link

@fmarangon fmarangon commented Jan 14, 2020

This bugfix caused an issue when using row expansion on a frozen datatable.

The line
this.updateExpandedRowsColspan();
in method init (datatable.js, row 40) calls getExpandedRows which relies on this.frozenTbody being already initialized, but at this point method setupScrolling() hasn't been called yet (it's called by this.renderDeferred(); in method init, row 65)

Should this issue be reopened or should I post another one?

This behaviour is reproducible up to RC.02

@fanste

This comment has been minimized.

Copy link
Contributor

@fanste fanste commented Jan 14, 2020

PR #5519

@melloware melloware modified the milestones: 8.0.RC1, 8.0.RC3 Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.