DatePicker: JavaScript error during ajax request

[JamieGHamilton]

Describe the defect
The datePicker widget javascript contains the method "_destroy" which gets called during an ajax request when the component is rerendered. This destroy method calls 2 methods: this.restoreOverlayAppend() and this.onOverlayHide() - neither function seems to be defined anywhere and creates javascript errors.

Reproducer

Environment:

• PF Version: 8.0
• JSF + version: MyFaces 2.3.6
• Affected browsers: ALL

To Reproduce
Steps to reproduce the behavior:

1. Setup page with example xhtml below
2. Monitor for javascript errors
3. Click button "click for javascript error"
4. See error: "this.restoreOverlayAppend is not a function"

Expected behavior
The datePicker destroy code should succeed without javascript errors.

Example XHTML

<h:form>
	<p:datePicker id="dp" />

	<p:commandButton id="ajaxButton"
	                 value="click for javascript error"
	                 process="dp"
	                 update="dp" />
</h:form>

Example Bean
no bean required

[melloware]

I can't reproduce?
pf-6641.zip

Run mvn clean jetty:run -Pmyfaces23 and navigate to http://localhost:8080/primefaces-test/test.xhtml

[JamieGHamilton]

MyFaces will capture and hide this exception so you have to turn on debugging and pause on caught exceptions.
I can reproduce it with your example:

[melloware]

I have my Chrome Console set to "preserve log" so any error thrown in the console remains and does not get cleared and I don't see it?

[JamieGHamilton]

In chrome you need the stop sign to be blue and the checkbox "Pause on caught exceptions"

[melloware]

I see it now thanks!

[melloware]

OK can you add this MonkeyPatch to your JS code that loads after PF and see if its fixed.

if ($.prime && $.prime.datePicker) {
    $.prime.datePicker.prototype._destroy = function() {
        this.hideOverlay();
    };
}

[JamieGHamilton]

Yes...it's fixed!

[melloware]

Thanks for reporting I would have never seen this if not for that break on JS error checkbox!

[JamieGHamilton]

No problem.

[tibor-both-cc]

Can the fix patched also to the 8.x.x versions?

[melloware]

Most likely not in 8.0 as the fix is already included in 10.0.0 and 11.0.0 and you have the MonkeyPatch you can use above for 8.0