Karma test throws "documentResizeListener is not a function" message in dialog.js #1314

Closed
nomis89 opened this Issue Nov 15, 2016 · 4 comments

Projects

None yet

4 participants

@nomis89
nomis89 commented Nov 15, 2016

I think the ngOnDestroy method in dialog.js wants to unsubscribe listeners which doesn't exist.

Also mentioned in this forum entry:
http://forum.primefaces.org/viewtopic.php?f=35&t=47860
Thanks

@Mrtcndkn
Contributor

Thanks i think the issue is what you mentioned i will review that and get back to you from here.

@Mrtcndkn Mrtcndkn self-assigned this Nov 15, 2016
@Mrtcndkn Mrtcndkn added the defect label Nov 15, 2016
@nomis89
nomis89 commented Nov 15, 2016

@Mrtcndkn nice, thanks for the fast reply :)

@albertosramires

@Mrtcndkn Any updates on this?

@Mrtcndkn Mrtcndkn added a commit that closed this issue Dec 9, 2016
@Mrtcndkn Mrtcndkn fixed #1314 e286c9e
@Mrtcndkn Mrtcndkn closed this in e286c9e Dec 9, 2016
@Mrtcndkn Mrtcndkn added this to the 1.1 milestone Dec 9, 2016
@Yoranium238
Yoranium238 commented Dec 13, 2016 edited

@Mrtcndkn This same issue exists in confirmdialog.js. Does this require a separate issue to be logged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment