Checkbox support for Listbox #1469

Closed
ntkolev opened this Issue Dec 1, 2016 · 5 comments

Projects

None yet

4 participants

@ntkolev
ntkolev commented Dec 1, 2016 edited

I'm submitting a ...

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

What is the motivation / use case for changing the behavior?
I would like to use the MultiSelect as a Listbox with checkboxes. The master checkbox/search capabilities make this component perfect for our needs.

The closest thing I could try is to hide the combo with display:none, and set the overlayVisible to true. The problem is that the overlay is hidden when the user clicks outside of it. It would be great if there was a way to fix it on the screen.

@Mrtcndkn Mrtcndkn added the review label Dec 1, 2016
@roni-frantchi
roni-frantchi commented Dec 1, 2016 edited

Thanks for the prompt response @Mrtcndkn .

Like in primefaces http://www.primefaces.org/showcase/ui/input/manyMenu.xhtml ?

I'd say, yes. Although there a couple of notable differences:

  1. On PrimeFaces SelectManyMenu clicking an item (not the checkbox of the item), unselects all other items. In PrimeNg's MultiSelect, clicking on an item is similar to clicking an item's checkbox.
  2. PrimeFaces SelectManyMenu doesn't have a built in Select All checkbox like PrimeNg's MultiSelect.

On both items, I'd say the PrimeNg's MultiSelect approach is the one we're looking for.

@Mrtcndkn
Contributor
Mrtcndkn commented Dec 1, 2016

Okey we will do it in 1.0.2 @roni-frantchi

@Mrtcndkn Mrtcndkn self-assigned this Dec 1, 2016
@Mrtcndkn Mrtcndkn added this to the 1.0.2 milestone Dec 1, 2016
@roni-frantchi

Awesome. Thanks so much @Mrtcndkn !

@cagataycivici cagataycivici changed the title from Use of MultiSelect like a Listbox with checkboxes to Checkbox support for Listbox Dec 6, 2016
@Mrtcndkn Mrtcndkn added a commit that closed this issue Dec 7, 2016
@Mrtcndkn Mrtcndkn fixed #1469 f412986
@Mrtcndkn Mrtcndkn closed this in f412986 Dec 7, 2016
@cagataycivici
Member

Reopening for code review.

@cagataycivici cagataycivici reopened this Dec 7, 2016
@Mrtcndkn Mrtcndkn added a commit that closed this issue Dec 7, 2016
@Mrtcndkn Mrtcndkn fixed #1469 a3b2144
@Mrtcndkn Mrtcndkn closed this in a3b2144 Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment