Disabled chips should not display close icon #1635

FallenRiteMonk opened this Issue Dec 20, 2016 · 0 comments


None yet

2 participants


I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

Plunkr not possible since the template still users rc6 which is missing chips module

Current behavior
Setting chips module disabled makes it impossible to remove a chip, but the x to remove them is still there

Expected behavior
If chips are disabled, remove the x in the upper right corner of every chip

Minimal reproduction of the problem with instructions
Just add a chip module with disabled set to true

What is the motivation / use case for changing the behavior?
In this way users are not confused with a nor working close x and the module could be used for only displaying to.

@cagataycivici cagataycivici changed the title from Blank chip bug to Disabled chips should not display close icon Dec 20, 2016
@cagataycivici cagataycivici self-assigned this Dec 20, 2016
@cagataycivici cagataycivici added this to the 1.1.1 milestone Dec 20, 2016
@cagataycivici cagataycivici added a commit that closed this issue Dec 20, 2016
@cagataycivici cagataycivici Fixed #1635 c08646e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment