Button label updates icon instead of label. #1685

tzvimg opened this Issue Dec 27, 2016 · 0 comments


None yet

2 participants

tzvimg commented Dec 27, 2016
[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

When label update after view initialization, the setter updates icon insead of label.

set label(val: string) {
        this._label = val;
        if(this.initialized) {
            this.domHandler.findSingle(this.el.nativeElement, '.ui-c').textContent = this._label;

The css selector should be .ui-button-text and not .ui-c;

@kryzys69 kryzys69 pushed a commit to kryzys69/primeng that referenced this issue Jan 15, 2017
kryzys69 Update button.ts
This simple change closes #1685 and #1719. I don't know what was the point of this change, but it was okay before commit b976a9d.
@cagataycivici cagataycivici self-assigned this Jan 18, 2017
@cagataycivici cagataycivici added this to the 2.0 milestone Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment