Replace Header and Footer with p-header and p-footer #1710

Closed
EddyP23 opened this Issue Dec 29, 2016 · 3 comments

Projects

None yet

4 participants

@EddyP23
EddyP23 commented Dec 29, 2016

Problem

In components/common/shared.ts selectors of Header and Footer components don't have prefix p- and even worse shadow real HTML elements <header> and <footer>. It makes detecting import problems miserable, as there is no error, if it can't recognise Header or Footer components.

Proposed Solution

Change selectors to p-header and p-footer to make it consistent to the whole prime-ng package.

@cagataycivici cagataycivici added this to the 2.0 milestone Dec 30, 2016
@cagataycivici cagataycivici self-assigned this Dec 30, 2016
@cagataycivici cagataycivici changed the title from [Bug] Selector's of Header and Footer components should not shadow valid HTML elements to Replace Header and Footer with p-header and p-footer Dec 30, 2016
@cagataycivici cagataycivici added a commit that closed this issue Dec 30, 2016
@cagataycivici cagataycivici Fixed #1710 e66afae
@Darktaelb

Help me. Trying to add p-footer with calendar for saving changes and have this error:
"p-footer is not a known element", i can't find a solution for this, "SharedModule" included in NgModule doesn't help

Text of module:
"@NgModule({
imports:[
ScheduleModule,
DialogModule,
InputMaskModule,
CheckboxModule,
BrowserModule,
FormsModule,
SharedModule

],
declarations:[
    EventCalendarComponent, JqueryForEventCalendarComponent
],
exports:[
    EventCalendarComponent
],
providers:[
    ConfirmationService

],
bootstrap:[]

})"

@nicovanbelle

I have the same issue.. The docs stating "Note that Header and Footer components should be imported and defined at directives section of your component for this to work." was not much of a help.

@Darktaelb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment