Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zone.js 0.11.4 #9989

Closed
leifjones opened this issue Mar 11, 2021 · 1 comment
Closed

Allow zone.js 0.11.4 #9989

leifjones opened this issue Mar 11, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@leifjones
Copy link

leifjones commented Mar 11, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
When upgrading from 11.2.3 to 11.3.0

Package "primeng" has an incompatible peer dependency to "zone.js" (requires "^0.10.2", would install "0.11.4")

Expected behavior
Given that (at least from our usage) there is no issue with current usage of PrimeNG's Tree features in an app using zone.js 0.11.4, no warning about peer dependencies

Minimal reproduction of the problem with instructions

  1. Starting place: primeng@11.2.3, zone.js@0.11.4
  2. ng update primeng karma @types/node @types/jasmine
  3. See output as mentioned above.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 11
  • PrimeNG version: 11
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version = 14.5.3

@yigitfindikli yigitfindikli self-assigned this Mar 11, 2021
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 11, 2021
@yigitfindikli yigitfindikli added this to the 11.3.1 milestone Mar 11, 2021
@leifjones
Copy link
Author

thanks @yigitfindikli !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants