Fade animations fails on some locales #1491

Merged
merged 1 commit into from Dec 20, 2016

Projects

None yet

2 participants

@sittingbool
Contributor

I had some issues with fading. i found out that in some of my browsers and in electron the value of opacity will have a comma instead of a dot as float separator. thats common for germany, because we write floats with comma instead of dot. maybe the local settings of the browser cause this issue but this code version is more stable in any case.

@sittingbool sittingbool Fix dot to comma issue in some (german) browsers
I had some issues with fading. i found out that in some of my browsers and in electron the value of opacity will have a comma instead of a dot as float separator. thats common for germany, because we write floats with comma instead of dot. maybe the local settings of the browser cause this issue but this code version is more stable in any case.
d1060f1
@sittingbool
Contributor

Would be great if you could merge this for the next version. Otherwise we can not update anymore. We had to fix this locally so far because otherwise growl would not work anymore and get stuck with a weird and too low opacity value. But sending a zip package around the dev team is not a solution ;).

@cagataycivici cagataycivici self-assigned this Dec 20, 2016
@cagataycivici cagataycivici added this to the 1.1.1 milestone Dec 20, 2016
@cagataycivici cagataycivici changed the title from Fix dot to comma issue in some (german) browsers to Fade animations fails on some locales Dec 20, 2016
@cagataycivici cagataycivici merged commit f5ad386 into primefaces:master Dec 20, 2016
@cagataycivici
Member

Thank you.

@sittingbool sittingbool deleted the sittingbool:patch-2 branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment