Fixed #1107 - Min height when label is null #1513

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@upmauro
Contributor
upmauro commented Dec 7, 2016 edited

Fixed #1107 min-height when the ui-dropdown-item have a null label.

min-height: 1em is the best way, because "em" is "Relative to the font-size of the element (2em means 2 times the size of the current font)"

Preview:

image

The same solution has applied on select2 in the past select2/select2@4530e74

@cagataycivici cagataycivici added this to the 1.1 milestone Dec 13, 2016
@cagataycivici cagataycivici self-assigned this Dec 13, 2016
@cagataycivici cagataycivici modified the milestone: 1.2, 1.1 Dec 15, 2016
@cagataycivici
Member

This looks a bit weird to me, I'll use the same approach we had for ui-dropdown-label-empty instead.

@cagataycivici
Member

screen shot 2016-12-20 at 10 33 18

@cagataycivici
Member

Fixed via #1626

@cagataycivici cagataycivici added defect and removed review labels Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment