Fixed #1505 - acceptVisible and rejectVisible not changing value #1514

Merged
merged 1 commit into from Dec 7, 2016

Projects

None yet

2 participants

@upmauro
Contributor
upmauro commented Dec 7, 2016

acceptVisible and rejectVisible is initialized just by declaration, so, if you change the value first time to false, the (ternary if) ever fail and the value will never change again.

@upmauro upmauro Fixed #1505 - acceptVisible and rejectVisible is initialized just by …
…declaration, so, if you change the value first time to false, the (ternary if) ever fail and the value will never change again.
e49b4c1
@cagataycivici cagataycivici added the defect label Dec 7, 2016
@cagataycivici cagataycivici added this to the 1.0.2 milestone Dec 7, 2016
@cagataycivici cagataycivici self-assigned this Dec 7, 2016
@cagataycivici cagataycivici merged commit afd48b5 into primefaces:master Dec 7, 2016
@cagataycivici
Member
cagataycivici commented Dec 7, 2016 edited

Shouldn't we also check undefined?

this.rejectVisible = (this.confirmation.rejectVisible == null ||  this.confirmation.rejectVisible == undefined) ? this.rejectVisible : this.confirmation.rejectVisible;

Or should we trust (null == undefined) = true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment