Expose `DomHandler` in library API. #1736

Merged
merged 1 commit into from Jan 18, 2017

Projects

None yet

2 participants

@memee
Contributor
memee commented Jan 5, 2017

DomHandler was a missing provider when one wanted to subclass and
modify some of primeng components. When we export it in public API
it'll be possible to subclass any component or subcomponent.

@memee memee Expose `DomHandler` in library API.
`DomHandler` was a missing provider when one wanted to subclass and
modify some of primeng components. When we export it in public API
it'll be possible to subclass any component or subcomponent.
b26101c
@cagataycivici
Member
cagataycivici commented Jan 9, 2017 edited

Shouldn't we export it from primeng at;

https://github.com/primefaces/primeng/blob/master/primeng.ts

import {DomHandler} from 'primeng/primeng';
@memee
Contributor
memee commented Jan 9, 2017

@cagataycivici there's

export * from './components/common/api';

in https://github.com/primefaces/primeng/blob/master/primeng.ts
which actually is doing it.

If we think of the best place it should be put in - I personally don't know. For me common/api was the first choice.

@cagataycivici cagataycivici self-assigned this Jan 18, 2017
@cagataycivici cagataycivici added this to the 2.0 milestone Jan 18, 2017
@cagataycivici cagataycivici merged commit 28f004f into primefaces:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment