Keyboard and ScreenReader support for TreeTable #1737

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

2 participants

@nhnb
nhnb commented Jan 5, 2017

This PR enables TreeTables to be used via keyboard and screen readers for improved accessibility.

It converts the expand/collapse toggle from a span-tag into a button tag. Adjusted css rules ensure that there is no visible difference. It adds two new attributes labelExpand and labelCollapse with appropriate defaults ("Expand" and "Collapse") in order to indicate the current state to screen readers.

@cagataycivici
Member

Thank you, I'll merge but replace button with anchor since we use anchors mostly for accessibility.

@cagataycivici cagataycivici merged commit 2ef70a6 into primefaces:master Jan 9, 2017
@cagataycivici cagataycivici self-assigned this Jan 9, 2017
@cagataycivici cagataycivici added this to the 2.0 milestone Jan 9, 2017
@cagataycivici cagataycivici added a commit that referenced this pull request Jan 9, 2017
@cagataycivici cagataycivici Refactor #1737 2dacee4
@cagataycivici cagataycivici changed the title from added keyboard and screenreader support to TreeTable to Keyboard and ScreenReader support for TreeTable Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment