Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable edit not work (Input disappears immediately after clicking cell) in react-dom@17.0.1 #1685

Closed
plantyoon opened this issue Nov 25, 2020 · 6 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@plantyoon
Copy link

I'm submitting a ... (check one with "x")

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
forked : https://codesandbox.io/s/nostalgic-herschel-iw8jj?file=/package.json
original : https://codesandbox.io/s/nifty-wiles-p4l8x

Current behavior

I wanted to use the edit function of the DataTable component. I followed by looking at the example, but when I clicked on the cell, the input was generated and disappeared immediately, so I couldn't edit it. It was the same if I used the same example. After a few tests, I found out that this was a version problem of the react-dom.
Look at my forked codesandbox. Otherwise, it is reproduced by replacing the react-dom version with 17. 0.1 in the original DataTable edit example. There was no problem with the react version being 17.0.1, but if the react-dom version becomes 17.0.1, there is a problem occurs.

Expected behavior

Regardless of the dependencies version, the functionality should work properly.

Please tell us about your environment:

  • React version:
  • react: 17.0.1
  • react-dom: 17.0.1
  • PrimeReact version:

5.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all
@mertsincan mertsincan self-assigned this Nov 26, 2020
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 26, 2020
@mertsincan
Copy link
Member

Hi,

Thanks a lot for the report! This issue is related to https://reactjs.org/blog/2020/08/10/react-v17-rc.html#changes-to-event-delegation
I'll check and get back to you asap.

Best Regards,

@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 27, 2020
@mertsincan mertsincan added this to the 5.0.2 milestone Nov 27, 2020
@sebamar
Copy link

sebamar commented Dec 14, 2020

Hi
this issue seems not to be solved yet, i still have the problem on version 5.0.2, on your example site in datatable / edit (first datatable) it is not possible to change the value in the dropdown 'status'

React: 16.14.0
Browser: Chrome, Firefox

Thanks for the support
Best Regards

@Priyajit08
Copy link

Hi,

The Issue seems to be still there. Please check the official site demo for cell edit even in that the Drop-downs diden't work.

@mertsincan mertsincan reopened this Dec 31, 2020
@mertsincan mertsincan modified the milestones: 5.0.2, 6.0.0-rc.1 Dec 31, 2020
@mertsincan
Copy link
Member

Hi all,

Thanks a lot for the update! Fixed now.

@subodhkalika
Copy link

subodhkalika commented Jan 16, 2021

Thank you for your effort.

The focus out now requires double click outside the cell or selection of two other cells.

@mertsincan
Copy link
Member

Hi @subodhkalika,

Fixed now. Thanks a lot for the report.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

5 participants