Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing param name in d.ts-files #236

Closed
MariuszKogut opened this issue Dec 7, 2017 · 0 comments
Closed

Missing param name in d.ts-files #236

MariuszKogut opened this issue Dec 7, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@MariuszKogut
Copy link
Contributor

MariuszKogut commented Dec 7, 2017

Hi there,
there is an general issue regarding your d.ts files. Please add a name for your event params.

Your d.ts-files:

    onChange?({originalEvent: Event, value: boolean}): void;

This declaration fires an tsc error: Error:(24, 37) TS7031: Binding element 'Event' implicitly has an 'any' type.

Fix:

    onChange?(e: {originalEvent: Event, value: boolean}): void;

Just add an parameter name and everything is fine!

Bye bye.
Mariusz

MariuszKogut added a commit to SwissLife-OSS/sl-primereact that referenced this issue Dec 7, 2017
cagataycivici added a commit that referenced this issue Dec 10, 2017
@cagataycivici cagataycivici self-assigned this Dec 10, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Dec 10, 2017
@cagataycivici cagataycivici added this to the 1.3.0 milestone Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants