Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages-Toast: Inconsistency #4077

Closed
EmirBoyaci opened this issue Feb 19, 2023 · 2 comments
Closed

Messages-Toast: Inconsistency #4077

EmirBoyaci opened this issue Feb 19, 2023 · 2 comments
Assignees
Labels
Component: Theme Issue or pull request is related to Theme Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@EmirBoyaci
Copy link
Contributor

Describe the bug

Hi,

Actually I don't know is it bug or not but it's clear that Messages and Toast components are inconsistent.

I am thinking these are inconsistent because these two components are just same, aren't they? From my point of view, these two components should(?) look exactly the same. If that's the case, maybe we can have one component (internally) which we are going to call from Toast and Messages components. So that, in the future they look exactly the same and we don't maintain two components together.

Toast
Screenshot 2023-02-19 at 16 16 51

Messages
Screenshot 2023-02-19 at 16 16 37

Reproducer

No response

PrimeReact version

9.1.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@EmirBoyaci EmirBoyaci added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 19, 2023
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 19, 2023
@melloware
Copy link
Member

Are you referring to the icons or the order in the demo or both?

@EmirBoyaci
Copy link
Contributor Author

EmirBoyaci commented Feb 19, 2023

Are you referring to the icons or the order in the demo or both?

Order is not a problem. I am referring the icons, and the content. As you can see in Toast component, we have summary bold and we have detail in a separate line. However, in Messages component, summary and detail are in the same line and summary is not bold. From my perspective, these should be exactly the same because these two components' difference are just usage. Toast is like notification, Messages is the inline version of that, isn't it? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

5 participants