Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale update to use ariaLabel method #6313

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

melloware
Copy link
Member

@melloware melloware commented Apr 5, 2024

Locale update to use ariaLabel method

I realized while doing @nitrogenous InputOtp review we were not using the ariaLabel method instead doing this repeated work when there are replacement variables in an Aria Label.

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 11:45am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 11:45am

@melloware melloware requested a review from gucal April 5, 2024 14:45
@melloware melloware added the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

1 similar comment
Copy link

github-actions bot commented Apr 5, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

github-actions bot commented Apr 5, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

github-actions bot commented Apr 9, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

github-actions bot commented Apr 9, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

github-actions bot commented Apr 9, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware merged commit 9253f35 into primefaces:master Apr 9, 2024
4 of 5 checks passed
@melloware melloware deleted the aria-labels branch April 9, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant