Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTABanner] Fix container width #265

Merged
merged 1 commit into from May 12, 2023
Merged

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented May 9, 2023

Summary

Adjust width property to avoid shrinking when using Stack or Grid components as wrappers.

List of notable changes:

  • added width: 100% to .CTABanner

What should reviewers focus on?

  • Using Stack or Grid components on a CTABanner works as expected and doesn't shrink the wrapper

Steps to test:

  1. Open the CTABanner component in storybook
  2. Add display:flex to the parent
  3. Verify that CTABanner behaves as described in the following issue.

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: f7e9b21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@josepmartins josepmartins merged commit 66f85ab into main May 12, 2023
15 of 17 checks passed
@josepmartins josepmartins deleted the josepmartins/CTABanner-wrapper branch May 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants