Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs with npx changeset step #1987

Merged
merged 5 commits into from Mar 9, 2022
Merged

Update contributing docs with npx changeset step #1987

merged 5 commits into from Mar 9, 2022

Conversation

cheshire137
Copy link
Member

What are you trying to accomplish?

This updates the documentation for contributors so that they're aware of npx changeset, hopefully so maintainers won't have to run this for them.

What approach did you choose and why?

Jon had to do it for me in #1985. Thought adding docs for it would cut that down!

What should reviewers focus on?

Meta, but should this change have a changeset entry??

Are additional changes needed?

  • No, this PR should be ok to ship as is. 馃殺

@cheshire137 cheshire137 requested a review from a team as a code owner March 9, 2022 16:59
@cheshire137 cheshire137 requested a review from simurai March 9, 2022 16:59
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2022

鈿狅笍 No Changeset found

Latest commit: 7f68614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jonrohan jonrohan merged commit 2a05ba6 into primer:main Mar 9, 2022
@cheshire137 cheshire137 deleted the main branch March 9, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants