From 62710db4811c13e2e7b729d67aafdb6b0bef12d3 Mon Sep 17 00:00:00 2001 From: simurai Date: Wed, 22 Feb 2023 15:48:29 +0900 Subject: [PATCH 1/4] Remove autocheck styles --- src/forms/form-validation.scss | 52 ---------------------------------- 1 file changed, 52 deletions(-) diff --git a/src/forms/form-validation.scss b/src/forms/form-validation.scss index e0c27b94ba..73d446c40a 100644 --- a/src/forms/form-validation.scss +++ b/src/forms/form-validation.scss @@ -1,55 +1,3 @@ -// Needs refactoring -// stylelint-disable selector-no-qualifying-type, selector-max-type -dl.form-group > dd, // TODO: Deprecate -.form-group > .form-group-body { - .form-control { - &.is-autocheck-loading, - &.is-autocheck-successful, - &.is-autocheck-errored { - // stylelint-disable-next-line primer/spacing - padding-right: 30px; // Leave some space for our validation icons - } - - &.is-autocheck-loading { - background-image: url('/images/spinners/octocat-spinner-16px.gif'); - } - - &.is-autocheck-successful { - background-image: url('/images/modules/ajax/success.png'); - } - - &.is-autocheck-errored { - background-image: url('/images/modules/ajax/error.png'); - } - } -} - -// Retinization of form validation icons that aren't octicons yet -@include retina-media-query { - dl.form-group > dd, // TODO: Deprecate - .form-group > .form-group-body { - .form-control { - &.is-autocheck-loading, - &.is-autocheck-successful, - &.is-autocheck-errored { - background-size: 16px 16px; - } - - &.is-autocheck-loading { - background-image: url('/images/spinners/octocat-spinner-32.gif'); - } - - &.is-autocheck-successful { - background-image: url('/images/modules/ajax/success@2x.png'); - } - - &.is-autocheck-errored { - background-image: url('/images/modules/ajax/error@2x.png'); - } - } - } -} - // Inline verification // This overrides primer's inline form stuff .status-indicator { From ad1989b054e09c6f6be142cbb3827ed145e398e0 Mon Sep 17 00:00:00 2001 From: simurai Date: Wed, 22 Feb 2023 17:50:26 +0900 Subject: [PATCH 2/4] Remove `status-indicator` --- src/forms/form-validation.scss | 54 ---------------------------------- 1 file changed, 54 deletions(-) diff --git a/src/forms/form-validation.scss b/src/forms/form-validation.scss index 73d446c40a..f1fd01b5f5 100644 --- a/src/forms/form-validation.scss +++ b/src/forms/form-validation.scss @@ -1,58 +1,4 @@ // Inline verification -// This overrides primer's inline form stuff -.status-indicator { - display: inline-block; - width: 16px; - height: 16px; - // stylelint-disable-next-line primer/spacing - margin-left: 5px; - - .octicon { - display: none; - } -} - -.status-indicator-success { - // Override primer - &::before { - content: ''; - } - - .octicon-check { - display: inline-block; - color: var(--color-success-fg); - fill: var(--color-success-fg); - } - - .octicon-x { - display: none; - } -} - -.status-indicator-failed { - // Override primer - &::before { - content: ''; - } - - .octicon-check { - display: none; - } - - .octicon-x { - display: inline-block; - color: var(--color-danger-fg); - fill: var(--color-danger-fg); - } -} - -.status-indicator-loading { - width: 16px; - background-image: url('/images/spinners/octocat-spinner-32-EAF2F5.gif'); - background-repeat: no-repeat; - background-position: 0 0; - background-size: 16px; -} .inline-form { display: inline-block; From f8debd4d7ea0508a2fefab2e7ad745eabc60618b Mon Sep 17 00:00:00 2001 From: simurai Date: Wed, 22 Feb 2023 18:02:07 +0900 Subject: [PATCH 3/4] Create beige-badgers-perform.md --- .changeset/beige-badgers-perform.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-badgers-perform.md diff --git a/.changeset/beige-badgers-perform.md b/.changeset/beige-badgers-perform.md new file mode 100644 index 0000000000..41fe6b8e8a --- /dev/null +++ b/.changeset/beige-badgers-perform.md @@ -0,0 +1,5 @@ +--- +"@primer/css": patch +--- + +Remove `autocheck` + `status-indicator` styles From 1c8b98cfcb53e21f253516dc62812129db6460a4 Mon Sep 17 00:00:00 2001 From: simurai Date: Wed, 22 Feb 2023 22:06:28 +0900 Subject: [PATCH 4/4] Lint --- src/forms/form-validation.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/forms/form-validation.scss b/src/forms/form-validation.scss index f1fd01b5f5..83c82fbdbd 100644 --- a/src/forms/form-validation.scss +++ b/src/forms/form-validation.scss @@ -1,3 +1,5 @@ +// stylelint-disable selector-no-qualifying-type, selector-max-type + // Inline verification .inline-form {