New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Figma documentation #404
Conversation
|
Thank you for taking this on @lukasoppermann ! 👏 🙏 so excited to have all component docs in one place. Questions about task list, what do these two refer to?
|
This is partially improved. It is the spacing between the badge and the variants at the very top
This is just how the figma react components are named and build |
|
@lukasoppermann The image issue looks like a permissions problem: Where you and @josepmartins able to get the images working in another prototype? |
This is actually normal for figma images. They don't allow browser get somehow. It used to work here: https://primer-af96a7b598-26441320.drafts.github.io/guides/figma/components/banner But it is broken there to. I think @josepmartins and @danielguillan will have a look once josep is back from his vacation. |
Co-authored-by: Daniel Guillan <danielguillan@github.com>
Co-authored-by: Daniel Guillan <danielguillan@github.com>
bc2c545
to
52b0085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! 🚀
| async function sourceFigmaData({actions, createNodeId, createContentDigest}) { | ||
| // Save the Primer Figma data to the GraphQL store | ||
| const json = await fetch( | ||
| `https://raw.githubusercontent.com/primer/figma/main/packages/web/generated/components.json`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this data get updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've set up a workflow that updates the JSON file daily (can be triggered on demand too). Also, we're planning to hook it up to the Figma library release process that is being worked on, so it's also triggered automatically when a new release is published.

This is the very beginning of adding figma to the new docs.
👀 Preview
Changes
Todo
component.thumbnails.propis an object with dynamic props. We should replace this with an array of entries['propertyName', 'propertyValue']so that it is graphQL compatible @danielguillan @josepmartinsactionListare not available. I think this may be, because it is not a component set CC: @danielguillan?