Updates TabNav docs and adds TabPanel docs #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If @ericwbailey confirms that arrow keys should not move focus or change the active tab in a TabNav, we should create an issue to fix the @primer/react implementation. |
ericwbailey
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
@mperrotti Confirming that arrow keys should not factor into TabNav.
Also added a suggestion and a question. Otherwise this looks good to me!
content/components/tab-nav.mdx
Outdated
| A tab nav is used to organize related content into different views within the same context. | ||
| A tab nav lets users navigate between related views in the same context. Each "tab" links to a different view that is shown when a user selects a tab. | ||
|
|
||
| A tab nav is always a set of links, and each tab should have a unique URL. |
There was a problem hiding this comment.
What do you think of having a sentence here that includes a link to tab panels, and the tab panels usage section having a sentence that includes a link to tab nav?
My thinking is it could help pre-empt folks who don't know the difference between the two components' use cases and provides a link for them to self-serve.
Co-authored-by: Eric Bailey <ericwbailey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous TabNav docs contained guidance that was intended for TabPanels.