New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on using multi level menus #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar suggestions and a few questions 🙂 excited about multi-level!
content/components/action-menu.mdx
Outdated
| width="960" | ||
| alt="" | ||
| alt="Action menu opened with a label for the trigger (button), overlay (menu), and the internal action list." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem to be a pattern used by macOS and Windows (maybe Linux too?), but I didn't realize "..." indicates a the menu item opens dialog until Max told me. It's not obvious - but I think it's ok to follow this pattern as long as it's not critical for users to know that a dialog will be opened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it can easily look like truncated text 😅 but I think it's interesting and we should try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that we shouldn't truncate action list items in menus anyway because you can't have tooltips or another way to read what's behind the truncation?
I remember that discussion we had on the command palette.
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
| Action menus are used for disambiguation, navigation, or to display secondary options. They appear when users interact with buttons, actions, or other controls. | ||
|
|
||
| [Primer React implementation](https://primer.style/react/ActionMenu) | ||
| [Documentation](/components/action-menu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for the explicit Documentation link, rather than just linking to the component docs from the main heading/title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for adding all of this detail! Looks great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more wording nitpicks, otherwise looks great!
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>



To support our internal product teams better in incorporating action menus I've updated our docs.
I've also updated our ActionList docs to avoid linking directly to the React components and I've added the nav list there as well.
Note: I still need to update the
alttext for the images but I wanted to share this early.