Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify why a TreeView should not be used for navigation #478

Merged
merged 5 commits into from May 9, 2023

Conversation

ericwbailey
Copy link
Contributor

This PR addresses a request in Slack by @howdyray. It adds a paragraph to explain usability expectations for the TreeView component, and how there may be a mismatch in expectation if used for static navigation.

@ericwbailey ericwbailey requested a review from a team as a code owner April 25, 2023 22:02
@ericwbailey ericwbailey temporarily deployed to github-pages April 25, 2023 23:39 — with GitHub Actions Inactive
@ericwbailey ericwbailey changed the title Clarify why a TreeView should not be used for nav Clarify why a TreeView should not be used for navigation Apr 26, 2023
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This can merge as-is, but it would be even better if in the "Accessibility" section we could explain how using a tree view as navigation creates a worse experience for ATs.

Co-authored-by: Josh Black <joshblack@github.com>
@ericwbailey ericwbailey temporarily deployed to github-pages May 1, 2023 23:31 — with GitHub Actions Inactive
@ericwbailey
Copy link
Contributor Author

@mperrotti I just pushed up a note about it, if you don't mind giving that a second review.

@ericwbailey ericwbailey merged commit 3ddea12 into main May 9, 2023
4 checks passed
@ericwbailey ericwbailey deleted the add-treeview-explanation branch May 9, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants