Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate font-based Octicons #108

Closed
aaronshekey opened this issue Jul 3, 2016 · 2 comments

Comments

@aaronshekey
Copy link
Contributor

commented Jul 3, 2016

It's a lot of work to support the font-based Octicons. Doing so in 4.0 has introduced some regressions #107. We also rely very heavily on grunt-webfont, which isn't the most active project out there. We won't be able to realistically dog food the font version since github.com has since switched to SVG.

I think we should consider deprecating font-based Octicons.

Thoughts @jonrohan?

@jonrohan

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

I can't think of any of our own properties that still use the webfont. I'd be down for deprecating it. Maybe 5.0?

@brillout

This comment has been minimized.

Copy link

commented Nov 25, 2016

A note about that in the readme and release notes would be convenient.

dmitshur added a commit to shurcooL-legacy/octicons that referenced this issue Jan 21, 2017

Deprecate package in favor of octiconssvg.
GitHub has deprecated the icon font version of Octicons in favor of
SVG. See primer/octicons#108, and
https://github.com/blog/2112-delivering-octicons-with-svg for
motivation.

Package github.com/shurcooL/octiconssvg should be used instead, which
provides Octicons in SVG format.

dmitshur added a commit to shurcooL-legacy/octicons that referenced this issue Jan 21, 2017

Deprecate package in favor of octiconssvg.
GitHub has deprecated the icon font version of Octicons in favor of SVG.
See primer/octicons#108, and
https://github.com/blog/2112-delivering-octicons-with-svg for
motivation.

Package github.com/shurcooL/octiconssvg should be used instead, which
provides Octicons in SVG format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.