Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eye-closed and request-changes icons have non-16 height #346

Open
dmitshur opened this issue Sep 8, 2019 · 0 comments

Comments

@dmitshur
Copy link
Contributor

commented Sep 8, 2019

I'm not sure if this is intentional or not, but reporting to find out.

There are 191 octicons in v9.1.1. 189 of them have height set to exactly "16". But the recently added "eye-closed" and "request-changes" icons are the first to have non-16 heights:

  • eye-closed has height "13.921463966369629"
  • request-changes has height "15"

Possibly related, the vertical alignment of https://octicons.github.com/icon/eye/ and https://octicons.github.com/icon/eye-closed/ is slightly mismatched.

Is this working as intended or an unintentional bug?

/cc @colinkeany @katmeister

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.