Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Installing on Windows #216

Closed
tajmone opened this issue Jan 18, 2017 · 2 comments
Closed

Error Installing on Windows #216

tajmone opened this issue Jan 18, 2017 · 2 comments

Comments

@tajmone
Copy link

tajmone commented Jan 18, 2017

I've installed primer-css (apparently succesfully) on Win 10, but I've got quite a few warnings and errors.

I think the problem arises from line 19 in package.json:

    "setup": "if [ ! -d \"node_modules\" ]; then npm install; fi",

because that is the line that show up in the CMD terp, followed by a Windows warning ! unexpected. (or something like it, my Win10 is not in English so I'm translating it). From this error onward, a long list of errors reports and warnings.

Line 19 looks pretty much bash script to me — Windows will fail the if ... fi block.

A second error follows shortly afteward, and from the npm-debug.log log file it looks like this one also has to do with a bash command (cwd) being imparted to Windows CMD:

75 verbose cwd D:\Programmazione\GitHub-CSS\primer-css\primer-css-4.4.0
76 error Windows_NT 10.0.14393

I'm fresh to Node.js, so I can't really help much except by reporting the issue here. Couldn't this script lines be replaced with pure Node commands, instead of Linux/Bash commands?

Anyhow, I've tested building primer-css and it worked, so they are not fatal errors.

@jonrohan
Copy link
Member

Hey thanks for the report, I have a fix in #217 I'm going to merge. Can you check and see if it's working?

@tajmone
Copy link
Author

tajmone commented Jan 19, 2017

Yes I confirm: I've reinstalled it from scratch and it came out spotless!

Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants