Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor components to stop using defaultProps #2758

Closed
manuelpuyol opened this issue Jan 10, 2023 · 0 comments · Fixed by #2759
Closed

Refactor components to stop using defaultProps #2758

manuelpuyol opened this issue Jan 10, 2023 · 0 comments · Fixed by #2759
Labels
react

Comments

@manuelpuyol
Copy link
Contributor

The use of defaultProps for function components is going to be removed in a future major version of React, and they are already warning users about it in the latest RC:

Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

We should update our component stop using defaultProps so we are unblocked before the next version releases.
@manuelpuyol manuelpuyol mentioned this issue Jan 12, 2023
Merged
6 tasks
manuelpuyol added a commit that referenced this issue Jan 23, 2023
@manuelpuyol
move defaultProps to function defaults (#2759)
693ce68 
I'm updating all non-deprecated components that use `defaultProps` to stop using it and using function defaults instead.
As described in the issue below, `defaultProps` is going to be deprecated so it'd be nice to be clear of it before the new React version is released.

Closes #2758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move defaultProps to function defaults primer/react
2 participants
@manuelpuyol @primer-css