Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting a modal dialog in TreeView causes a crash. #4015

Closed
keithamus opened this issue Dec 4, 2023 · 2 comments · Fixed by #4013
Closed

Putting a modal dialog in TreeView causes a crash. #4015

keithamus opened this issue Dec 4, 2023 · 2 comments · Fixed by #4013
Labels
bug Something isn't working component: TreeView Issues related to the TreeView component react

Comments

@keithamus
Copy link
Member

Description

When adding a <dialog> element within the contents of a TreeView, and showing the dialog as modal, it will trap the focus to the contents of the dialog, however moving the focus causes TreeView to check where focus is, and assumes the next items to be within the TreeView. This is not the case for Dialogs.

Steps to reproduce

  1. Use a <TreeView>.
  2. Add a <dialog> in the contents of the TreeView and call .showModal()
  3. See an error Element is not a treeitem.

Version

v36.3.1

Browser

Chrome, Safari, Firefox, Edge, iOS Safari

@keithamus keithamus added the bug Something isn't working label Dec 4, 2023
@joshblack joshblack added the component: TreeView Issues related to the TreeView component label Dec 4, 2023
@lesliecdubs
Copy link
Member

@keithamus are you running into a crash in a particular area of the product that prompted this bug report? Understanding where this is showing up live (if at all) will help with prioritization.

@keithamus
Copy link
Member Author

I've just added this issue for tracking #4013, which is an attempt to split out the dialog work in #3840. I discovered the crash in #3840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: TreeView Issues related to the TreeView component react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants