Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Pagination to TypeScript #1047

Merged
merged 8 commits into from
Feb 19, 2021
Merged

Conversation

VanAnderson
Copy link
Contributor

@VanAnderson VanAnderson commented Feb 12, 2021

This PR migrates the Pagination component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021

🦋 Changeset detected

Latest commit: a5389b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/6s0z7dkb3
✅ Preview: https://primer-components-git-vananderson-pagination-tsx-migration.primer.now.sh

@VanAnderson VanAnderson changed the title Migrate PointerBox to TypeScript Migrate Pagination to TypeScript Feb 12, 2021
@VanAnderson VanAnderson mentioned this pull request Feb 12, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 12, 2021 18:07 Inactive
@VanAnderson
Copy link
Contributor Author

forgot to export PaginationProps! done in 43c79d6

@VanAnderson VanAnderson marked this pull request as ready for review February 12, 2021 18:14
@vercel vercel bot temporarily deployed to Preview February 12, 2021 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview February 12, 2021 18:38 Inactive
@VanAnderson
Copy link
Contributor Author

8fb049d should fix the last failing TS error 🤞

@vercel vercel bot temporarily deployed to Preview February 12, 2021 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview February 12, 2021 18:58 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Just left one suggestion about the PaginationProps type

src/Pagination/Pagination.tsx Outdated Show resolved Hide resolved
src/Pagination/Pagination.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview February 18, 2021 15:28 Inactive
@VanAnderson VanAnderson force-pushed the VanAnderson/Pagination-tsx-migration branch from 21af95e to 53edf5e Compare February 18, 2021 15:37
@vercel vercel bot temporarily deployed to Preview February 18, 2021 15:37 Inactive
@VanAnderson VanAnderson force-pushed the VanAnderson/Pagination-tsx-migration branch from 53edf5e to cf6bb0b Compare February 18, 2021 15:44
@vercel vercel bot temporarily deployed to Preview February 18, 2021 15:44 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 16:40 Inactive
@colebemis colebemis merged commit a5a827e into main Feb 19, 2021
@colebemis colebemis deleted the VanAnderson/Pagination-tsx-migration branch February 19, 2021 19:22
@github-actions github-actions bot mentioned this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants