TextInputWithTokens - adds the ability to hide text input tokens after a certain number #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73a3caf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
The snapshots that are failing in this branch are also failing on |
colebemis
reviewed
Oct 22, 2021
| @@ -172,6 +210,16 @@ function TextInputWithTokensInnerComponent<TokenComponentType extends AnyReactCo | |||
| } | |||
| } | |||
|
|
|||
| const focusInput: MouseEventHandler = () => { | |||
| combinedInputRef.current?.focus() | |||
There was a problem hiding this comment.
This makes sure the actual <input /> gets focus no matter where in the in the input wrapper the user clicks (except for clicking on tokens)
colebemis
reviewed
Oct 22, 2021
| @@ -29,6 +29,18 @@ const LabelledTextInputWithTokens: React.FC<TextInputWithTokensProps> = ({onToke | |||
| </> | |||
| ) | |||
|
|
|||
| // describe('axe test', () => { | |||
There was a problem hiding this comment.
Are you planning to uncomment this?
colebemis
reviewed
Oct 22, 2021
| for (const tokenLabel of allTokenLabels) { | ||
| const tokenNode = getByText(tokenLabel) | ||
| expect(tokenNode).toBeDefined() | ||
| } |
There was a problem hiding this comment.
Thank you for always writing such thorough tests ❤️
mperrotti
force-pushed
the
mp/token-input-truncation
branch
from
51aeb44
to
8565a51
Compare
colebemis
reviewed
Oct 27, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Screen.Recording.10-19-2021.at.2.27.PM.mp4
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.