Updates visual design of Checkbox and Radio inputs #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0637a09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…x-and-radio-styles
…er/react into mp/update-checkbox-and-radio-styles
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Looks great! Its hard to test indeterminate if I remember correctly, so I'm not sure if its covered here? But just in case it might be missing here's a line for checkbox https://github.com/primer/view_components/blob/main/app/components/primer/alpha/text_field.pcss#L618
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates PRC Checkbox and Radio inputs to visually match the PVC Checkbox and Radio inputs
Closes https://github.com/github/primer/issues/1024
Screenshots
Radio
Before
After
Checkbox
Before
After
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.