Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create adr-019-sx-style-usage.md #3986

Closed
wants to merge 2 commits into from
Closed

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Nov 29, 2023

There are a variety of different uses of sx and style in our code base. This makes it hard to do static analysis for code mods & liniting. Additionally some of the usage have a negative impact performance.

This ADR is supposed to address those issues by suggesting some patterns for everyone to use.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 3694768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 29, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.56 KB (0%)
dist/browser.umd.js 105.1 KB (0%)

@lesliecdubs
Copy link
Member

Hey @lukasoppermann, are the "assignees" on this PR the people you are seeking reviews from on this ADR? Or are you looking to collaborate on the content, as it looks like we're missing docs on the decision?

@keithamus
Copy link
Member

Matt and I are to assist in filling in some of the technical aspects of how the sx attribute is used and how we may lint for it.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 4, 2024
@github-actions github-actions bot closed this Feb 11, 2024
@github-actions github-actions bot deleted the adr-019-sx-style-usage branch February 11, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR skip changeset This change does not need a changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants