New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create adr-019-sx-style-usage.md #3986
Conversation
|
size-limit report 📦
|
|
Hey @lukasoppermann, are the "assignees" on this PR the people you are seeking reviews from on this ADR? Or are you looking to collaborate on the content, as it looks like we're missing docs on the decision? |
|
Matt and I are to assist in filling in some of the technical aspects of how the sx attribute is used and how we may lint for it. |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
There are a variety of different uses of
sxandstylein our code base. This makes it hard to do static analysis for code mods & liniting. Additionally some of the usage have a negative impact performance.This ADR is supposed to address those issues by suggesting some patterns for everyone to use.
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.