From 0cda8274a2448b24650d1ad29315c5abcb669a61 Mon Sep 17 00:00:00 2001 From: Rafael Oleza Date: Fri, 27 Sep 2019 13:27:31 +0200 Subject: [PATCH 1/2] Use open attribute on the DetailsBase component --- src/Details.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Details.js b/src/Details.js index 359f94f2e23..6b8d8b290df 100644 --- a/src/Details.js +++ b/src/Details.js @@ -23,8 +23,8 @@ function getRenderer(children) { return typeof children === 'function' ? children : () => children } -function DetailsBase({children, overlay, render = getRenderer(children), defaultOpen = false, ...rest}) { - const [open, setOpen] = useState(defaultOpen) +function DetailsBase({children, overlay, render = getRenderer(children), open: defaultOpen, ...rest}) { + const [open, setOpen] = useState(!!defaultOpen) const ref = useRef(null) const closeMenu = useCallback( @@ -68,7 +68,7 @@ Details.defaultProps = { Details.propTypes = { children: PropTypes.oneOfType([PropTypes.node, PropTypes.func]), className: PropTypes.string, - defaultOpen: PropTypes.bool, + open: PropTypes.bool, overlay: PropTypes.bool, render: PropTypes.func, theme: PropTypes.object, From ed6969618e791d8a47df3da3210f0185e4f7e644 Mon Sep 17 00:00:00 2001 From: Rafael Oleza Date: Fri, 27 Sep 2019 13:27:40 +0200 Subject: [PATCH 2/2] Reenable Details test --- src/__tests__/Details.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/__tests__/Details.js b/src/__tests__/Details.js index f485db2bf2e..78116a3af6f 100644 --- a/src/__tests__/Details.js +++ b/src/__tests__/Details.js @@ -57,7 +57,7 @@ describe('Details', () => { wrapper.unmount() }) - xit('Does not toggle or prevent click events when you click inside', () => { + it('Does not toggle or prevent click events when you click inside', () => { const wrapper = mount(
{({open}) => (