Add Grid type definitions #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/akaflcu6d |
dmarcey
approved these changes
Mar 17, 2020
Contributor
dmarcey
left a comment
dmarcey
left a comment
There was a problem hiding this comment.
👍 Looks good. One small suggestion about the placement of the interface within the declare file.
Comment on lines
+192
to
+194
| export interface GridProps extends BoxProps, StyledSystem.GridProps, Omit<React.HTMLAttributes<HTMLSpanElement>, 'color'> {} | ||
|
|
||
| export const Grid: React.FunctionComponent<GridProps> |
Contributor
There was a problem hiding this comment.
nit: should we put this above the CounterLabelProps? Right now it's separating the CounterLabelProps from the export const CounterLabel... line.
Author
There was a problem hiding this comment.
yes good call! This file need some alphabetizing love as well at some point!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
Gridwas missing type definitions 😬Closes #718
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.