Skip to content

Add Grid type definitions #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Add Grid type definitions #719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ff8d76
add Grid type definitions
Mar 17, 2020
55e20bb
move order of imports
Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ declare module '@primer/components' {

export const CounterLabel: React.FunctionComponent<CounterLabelProps>

export interface GridProps extends BoxProps, StyledSystem.GridProps, Omit<React.HTMLAttributes<HTMLSpanElement>, 'color'> {}

export const Grid: React.FunctionComponent<GridProps>
Comment on lines +194 to +196
Copy link
Contributor

@dmarcey dmarcey Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we put this above the CounterLabelProps? Right now it's separating the CounterLabelProps from the export const CounterLabel... line.

Copy link
Author

@emplums emplums Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good call! This file need some alphabetizing love as well at some point!


export interface LabelProps extends CommonProps, Omit<React.HTMLAttributes<HTMLSpanElement>, 'color'> {
outline?: boolean
variant?: 'small' | 'medium' | 'large' | 'xl'
Expand Down Expand Up @@ -457,6 +461,11 @@ declare module '@primer/components/src/Flash' {
export default Flash
}

declare module '@primer/components/src/Grid' {
import {Grid} from '@primer/components'
export default Grid
}

declare module '@primer/components/src/CounterLabel' {
import {CounterLabel} from '@primer/components'
export default CounterLabel
Expand Down