diff --git a/.changeset/gentle-peas-kick.md b/.changeset/gentle-peas-kick.md new file mode 100644 index 00000000000..bedc8eeafdd --- /dev/null +++ b/.changeset/gentle-peas-kick.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Popover: add missing shadow diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-colorblind-linux.png index 6b14b408988..6f5105e54e8 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-dimmed-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-dimmed-linux.png index a51d82201d3..30ac35ea198 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-dimmed-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-dimmed-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-high-contrast-linux.png index 07ad3ee495e..b896669a01e 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-linux.png index 6b14b408988..6f5105e54e8 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-tritanopia-linux.png index 6b14b408988..6f5105e54e8 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-tritanopia-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-colorblind-linux.png index ca51fb4df02..4100192d1a9 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-high-contrast-linux.png index 8f4b3d9065e..4c58954ffe8 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-linux.png index ca51fb4df02..4100192d1a9 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-tritanopia-linux.png index ca51fb4df02..4100192d1a9 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-tritanopia-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-colorblind-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-dimmed-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-dimmed-linux.png index 61deb815c6b..4f1f120e923 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-dimmed-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-dimmed-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-high-contrast-linux.png index c22c3a38092..bb7ca87369b 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-tritanopia-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-tritanopia-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-colorblind-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-high-contrast-linux.png index 7ae32df9e9f..e4b98e0bd13 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-tritanopia-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-tritanopia-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-colorblind-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-dimmed-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-dimmed-linux.png index 61deb815c6b..4f1f120e923 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-dimmed-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-dimmed-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-high-contrast-linux.png index c22c3a38092..bb7ca87369b 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-tritanopia-linux.png index 028f5c1f9bd..2aa14a4d7f1 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-tritanopia-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-colorblind-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-colorblind-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-colorblind-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-colorblind-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-high-contrast-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-high-contrast-linux.png index 7ae32df9e9f..e4b98e0bd13 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-high-contrast-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-high-contrast-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-linux.png differ diff --git a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-tritanopia-linux.png b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-tritanopia-linux.png index c2bafd00a5f..de31bd56740 100644 Binary files a/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-tritanopia-linux.png and b/.playwright/snapshots/components/Popover.test.ts-snapshots/Popover-Playground-light-tritanopia-linux.png differ diff --git a/packages/react/src/Popover/Popover.module.css b/packages/react/src/Popover/Popover.module.css index 5eacfae88c4..80db25623bf 100644 --- a/packages/react/src/Popover/Popover.module.css +++ b/packages/react/src/Popover/Popover.module.css @@ -18,8 +18,8 @@ margin-right: auto; margin-left: auto; background-color: var(--overlay-bgColor); - border: var(--borderWidth-thin) solid var(--borderColor-default); border-radius: var(--borderRadius-medium); + box-shadow: var(--shadow-floating-small); /* Carets */ &::before,