Skip to content

Conversation

@lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Dec 3, 2025

Closes https://github.com/github/primer/issues/6255
Relevant Slack thread: https://github.slack.com/archives/CSGAVNZ19/p1764777458569129

Radio button uses wrong colors when disabled and checked

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings December 3, 2025 18:49
@lukasoppermann lukasoppermann requested a review from a team as a code owner December 3, 2025 18:49
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: dd54466

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the disabled state styling for checked Radio controls by replacing incorrect generic tokens with appropriate control-specific design tokens. The change ensures visual consistency with other form controls like Checkbox and aligns with the Primer design system's token naming conventions.

Key changes:

  • Updated disabled checked radio styling to use control-checked-fgColor-disabled and control-checked-bgColor-disabled tokens instead of fgColor-muted
  • Added a changeset documenting this as a patch release

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/Radio/Radio.module.css Updated disabled checked state to use correct control-specific design tokens for background and border colors
.changeset/forty-aliens-shine.md Added changeset documenting the token correction as a patch release

Copy link
Contributor

@llastflowers llastflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✅

I also created and connected an issue for this in Primer Quality since it is definitely a quality improvement, so we can track this as part of the current sprint!

@lukasoppermann lukasoppermann added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 1d8759a Dec 3, 2025
61 checks passed
@lukasoppermann lukasoppermann deleted the lukasoppermann/radio-disabled-fix branch December 3, 2025 20:38
@primer primer bot mentioned this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants