-
Notifications
You must be signed in to change notification settings - Fork 646
Lukasoppermann/radio disabled fix #7267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dd54466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the disabled state styling for checked Radio controls by replacing incorrect generic tokens with appropriate control-specific design tokens. The change ensures visual consistency with other form controls like Checkbox and aligns with the Primer design system's token naming conventions.
Key changes:
- Updated disabled checked radio styling to use
control-checked-fgColor-disabledandcontrol-checked-bgColor-disabledtokens instead offgColor-muted - Added a changeset documenting this as a patch release
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/Radio/Radio.module.css | Updated disabled checked state to use correct control-specific design tokens for background and border colors |
| .changeset/forty-aliens-shine.md | Added changeset documenting the token correction as a patch release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✅
I also created and connected an issue for this in Primer Quality since it is definitely a quality improvement, so we can track this as part of the current sprint!
Closes https://github.com/github/primer/issues/6255
Relevant Slack thread: https://github.slack.com/archives/CSGAVNZ19/p1764777458569129
Radio button uses wrong colors when disabled and checked
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist