Skip to content

Update UnderlineNav.Link prop type #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Update UnderlineNav.Link prop type #727

merged 1 commit into from
Mar 23, 2020

Conversation

@emplums
Copy link

@emplums emplums commented Mar 23, 2020

This PR loosens the prop type definition for UnderlineNav.Link's as prop - it allows any node instead of just strings or functions. The PropTypes.func wasn't recognizing elements passed in. PropTypes.node encompasses strings, elements, functions, etc.

Addresses: https://github.slack.com/archives/CT16VV4R5/p1584981111066700?thread_ts=1584716771.042300&cid=CT16VV4R5

@emplums emplums added the minor release new features label Mar 23, 2020
@emplums emplums requested a review from BinaryMuse March 23, 2020 19:40
@vercel
Copy link

vercel bot commented Mar 23, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/omn3n4p21
✅ Preview: https://primer-components-git-underlinenav-type.primer.now.sh

BinaryMuse
BinaryMuse approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emplums emplums changed the base branch from master to minor March 23, 2020 22:03
@emplums emplums changed the title update prop type to node Update UnderlineNav.Link prop type Mar 23, 2020
@emplums emplums merged commit c5a1322 into minor Mar 23, 2020
@emplums emplums deleted the underlinenav-type branch March 23, 2020 22:03
@emplums emplums mentioned this pull request Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BinaryMuse BinaryMuse BinaryMuse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

minor release new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emplums @BinaryMuse