Minor Release Tracking PR (currently 16.3.0) #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`className` is a default DOM-level prop in React, and it feels wrong to omit this since it's possible in vanilla JS to pass this. `css` is exposed via styled-components, but only works with the Babel plugin, which rewrites any element with a `css` prop and converts it into a proper styled-component component. See https://styled-components.com/docs/api#css-prop for more information.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/lwunfr14w |
Fix DropdownProps type intersections
emplums
changed the title
added 2 commits
March 23, 2020 14:38
Add `className` and `css` to `BaseProps`
Update UnderlineNav.Link prop type
Let 'TextInput' use 'maxWidth' and 'minWidth' from 'styled-system'
feat(Popover): Add Popover component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the tracking PR for the next minor release (currently 16.3.0)
classNameandcssto BaseProps TypeScript type AddclassNameandcsstoBaseProps#726 @BinaryMuse