Skip to content

Minor Release Tracking PR (currently 17.1.0) #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 2, 2020
Merged

Minor Release Tracking PR (currently 17.1.0) #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
20179ff
update version
Mar 30, 2020
f8b9ae7
Merge branch 'master' into minor
Mar 30, 2020
126fc95
type fixes
Apr 2, 2020
5990c71
Merge branch 'master' into minor
Apr 2, 2020
9baf251
Update package.json
Apr 2, 2020
bb43590
Merge branch 'minor' into dropdown-hotfix
Apr 2, 2020
a60af18
add export back in
Apr 2, 2020
d61e376
couple more type tweaks
Apr 2, 2020
77923b3
Merge pull request #742 from primer/dropdown-hotfix
Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,21 +157,20 @@ declare module '@primer/components' {

export const StyledOcticon: React.FunctionComponent<StyledOcticonProps>

export interface DropdownProps extends DetailsProps, Omit<React.HTMLAttributes<HTMLElement>, 'color'> {}

export interface DropdownItem extends CommonProps, Omit<React.HTMLAttributes<HTMLLIElement>, 'color'> {}
export interface DropdownProps extends DetailsProps {}
export interface DropdownItemProps extends CommonProps, Omit<React.HTMLAttributes<HTMLLIElement>, 'color'> {}

export interface DropdownMenuProps extends CommonProps, Omit<React.HTMLAttributes<HTMLUListElement>, 'color'> {
direction?: 'ne'| 'e'| 'se'| 's'| 'sw'| 'w'
}

export interface DropdownButtonProps extends ButtonProps, Omit<React.HTMLAttributes, 'color'> {}
export interface DropdownButtonProps extends ButtonProps {}

export interface DropdownCaretProps extends CommonProps, Omit<React.HTMLAttributes<HTMLDivElement>, 'color'> {}

export const Dropdown: React.FunctionComponent<DropdownProps> & {
Menu: React.FunctionComponent<DropdownMenuProps>
Item: React.FunctionComponent<DropdownProps>
Item: React.FunctionComponent<DropdownItemProps>
Button: React.FunctionComponent<DropdownButtonProps>
Caret: React.FunctionComponent<DropdownCaretProps>
}
Expand Down Expand Up @@ -308,7 +307,7 @@ declare module '@primer/components' {
selected?: boolean
}

export interface SelectMenuFooterProps extends CommonProps, Omit<React.FooterHTMLAttributes<HTMLElement>, 'color'> {}
export interface SelectMenuFooterProps extends CommonProps, Omit<React.HTMLAttributes<HTMLElement>, 'color'> {}
Copy link
Author

@emplums emplums Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FooterAttributes isn't a thing


export interface SelectMenuDividerProps extends CommonProps, Omit<React.HTMLAttributes<HTMLDivElement>, 'color'> {}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@primer/components",
"version": "17.0.0",
"version": "17.1.0",
"description": "Primer react components",
"main": "dist/index.umd.js",
"module": "dist/index.esm.js",
Expand Down