71 allocations

Use mutation on `#call` hash instead of `Hash#except`
primer · Jan 26, 2021 · 8e4dab3 · 8e4dab3
1 parent cfef478
commit 8e4dab3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/primer/classify.rb b/lib/primer/classify.rb
@@ -111,10 +111,12 @@ class << self
       def call(classes: "", style: nil, **args)
         extracted_results = extract_hash(args)
 
-        {
-          class: [validated_class_names(classes), extracted_results[:classes]].compact.join(" ").presence,
-          style: [extracted_results[:styles], style].compact.join("").presence,
-        }.merge(extracted_results.except(:classes, :styles))
+        extracted_results[:class] = [validated_class_names(classes), extracted_results[:classes]].compact.join(" ").presence
+        extracted_results[:style] = [extracted_results[:styles], style].compact.join("").presence
+        extracted_results.delete(:classes)
+        extracted_results.delete(:styles)
+
+        extracted_results
       end
 
       private

diff --git a/test/primer/classify_test.rb b/test/primer/classify_test.rb
@@ -287,7 +287,7 @@ def test_limits_allocations
     values = { align_self: :center, width: :fit, p: 4, m: 1, border: :top, box_shadow: true, color: :red, visibility: :hidden}
     Primer::Classify.call(**values)
 
-    assert_allocations 77 do
+    assert_allocations 71 do
       Primer::Classify.call(**values)
     end
   end