Asset compilation failures should break the build #2426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Problems reported during asset compilation do not currently break the build, which lets TypeScript compiler errors into main.
Integration
No changes required in production.
Risk Assessment
What approach did you choose and why?
This PR contains a fix for a compiler error introduced in #2414. The build did not fail because of the way our script/build-assets script is written, so that's been fixed too.
Accessibility