Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset compilation failures should break the build #2426

Merged
merged 2 commits into from Dec 5, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Dec 5, 2023

What are you trying to accomplish?

Problems reported during asset compilation do not currently break the build, which lets TypeScript compiler errors into main.

Integration

No changes required in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

This PR contains a fix for a compiler error introduced in #2414. The build did not fail because of the way our script/build-assets script is written, so that's been fixed too.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 9ee7f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added javascript Pull requests that update Javascript code patch release labels Dec 5, 2023
@camertron camertron marked this pull request as ready for review December 5, 2023 19:48
@camertron camertron requested a review from a team as a code owner December 5, 2023 19:48
@camertron camertron merged commit 78dd9dd into main Dec 5, 2023
32 checks passed
@camertron camertron deleted the allow_asset_comp_to_break_build branch December 5, 2023 23:01
@primer primer bot mentioned this pull request Dec 5, 2023
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants