From 8904bb1e4c6eb7ee13725cd8c993948ca6f178e4 Mon Sep 17 00:00:00 2001 From: Justin Kenyon Date: Tue, 12 Dec 2023 11:51:51 -0500 Subject: [PATCH 1/3] Add failing test for `font_size` and `border_radius` --- test/lib/classify/utilities_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/lib/classify/utilities_test.rb b/test/lib/classify/utilities_test.rb index 7b2fffcda3..aa0ca7bd58 100644 --- a/test/lib/classify/utilities_test.rb +++ b/test/lib/classify/utilities_test.rb @@ -104,6 +104,7 @@ def test_classes_to_args assert_equal('mr: 1, mb: 2, classes: "foo"', Primer::Classify::Utilities.classes_to_args("mr-1 mb-2 foo")) assert_equal('classes: "foo"', Primer::Classify::Utilities.classes_to_args("foo")) assert_equal("mx: :auto", Primer::Classify::Utilities.classes_to_args("mx-auto")) + assert_equal("font_size: 3, border_radius: 0", Primer::Classify::Utilities.classes_to_args("f3 rounded-0")) assert_equal('mr: [1, 2], classes: "baz bin"', Primer::Classify::Utilities.classes_to_args("mr-1 mr-sm-2 baz bin")) assert_equal('mr: [1, nil, 2], classes: "foo bar"', Primer::Classify::Utilities.classes_to_args("mr-1 mr-md-2 foo bar")) end From 6a41200a0428c28e401960876b94413a38cc469b Mon Sep 17 00:00:00 2001 From: Justin Kenyon Date: Tue, 12 Dec 2023 11:53:09 -0500 Subject: [PATCH 2/3] Add support for `font_size` and `border_radius` --- lib/primer/classify/utilities.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/primer/classify/utilities.rb b/lib/primer/classify/utilities.rb index 2872778ca0..67e2caaf95 100644 --- a/lib/primer/classify/utilities.rb +++ b/lib/primer/classify/utilities.rb @@ -27,7 +27,9 @@ class Utilities "^height" => "h", "^color-bg" => "bg", "^color-border" => "border_color", - "^color-fg" => "color" + "^color-fg" => "color", + "^f" => "font_size", + "^rounded" => "border_radius" }.freeze SUPPORTED_KEY_CACHE = Hash.new { |h, k| h[k] = !UTILITIES[k].nil? } From b004322fd2e75c0caf30631f9b82b10634e89913 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 12 Dec 2023 09:54:41 -0800 Subject: [PATCH 3/3] Adding changeset --- .changeset/four-shoes-think.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/four-shoes-think.md diff --git a/.changeset/four-shoes-think.md b/.changeset/four-shoes-think.md new file mode 100644 index 0000000000..920bbccf58 --- /dev/null +++ b/.changeset/four-shoes-think.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": minor +--- + +Support font_size and border_radius in classify/utilities