Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codespaces prebuilds (again) #2552

Merged
merged 3 commits into from Jan 31, 2024
Merged

Fix codespaces prebuilds (again) #2552

merged 3 commits into from Jan 31, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR fixes our codespaces prebuild by:

  1. updating our bundler version
  2. letting bundle install handle installing the right bundler version automatically instead of doing it in the Dockerfile

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

…ng bundle install will handle installing the right version automatically
@camertron camertron added the skip changeset Pull requests that don't change the library output label Jan 31, 2024
Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 0fc30d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron marked this pull request as ready for review January 31, 2024 19:39
@camertron camertron requested a review from a team as a code owner January 31, 2024 19:39
@camertron camertron requested a review from a team as a code owner January 31, 2024 21:26
@camertron camertron merged commit 04365ae into main Jan 31, 2024
29 of 30 checks passed
@camertron camertron deleted the fix_codespaces_prebuild branch January 31, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants