Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Minor refactoring. Can't namespace portlets quite yet.

  • Loading branch information...
commit fd92750457aba02cdb7c04c61e33801083f2ba47 1 parent 3301f36
@peakpg peakpg authored
View
4 test/factories.rb
@@ -52,6 +52,10 @@
m.name "Sample Portlet"
end
+# Portlets happen to be Non-versioned right now, but this abstracts that in case it changes later.
+Factory.define :non_versioned_block, :parent=>:portlet do |m|
+end
+
Factory.define :html_block, :class => Cms::HtmlBlock do |m|
m.name "About Us"
m.content "<h1>About Us</h1>\n<p>Lorem ipsum dolor sit amet...</p>"
View
2  test/unit/lib/content_block_test.rb
@@ -267,7 +267,7 @@ def test_deleting_when_connected_to_page
class NonVersionedContentBlockConnectedToAPageTest < ActiveSupport::TestCase
def setup
@page = Factory(:page, :section => root_section)
- @block = DynamicPortlet.create!(:name => "Non-Versioned Content Block")
+ @block = Factory(:non_versioned_block, :name => "Non-Versioned Content Block")
@page.create_connector(@block, "main")
reset(:page, :block)
end
View
4 todo_list.txt
@@ -1,9 +1,11 @@
For 3.4, currently working on namespacing
+* Portlets need to be namespaced under cms_ as well (This seems to cause issues with DynamicAttribute saving, so might pass on this one.)
+
+
* Make cms_ an optional prefix for tables.
* Associations from versions_tables have cms_block_name_id
-* Portlets need to be namespaced under cms_ as well
Gems to Publish (once its live)
============
Please sign in to comment.
Something went wrong with that request. Please try again.