Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup instructions #19

Open
wants to merge 1 commit into
base: development_v2
from

Conversation

@c-w
Copy link

c-w commented Dec 19, 2019

This pull request fixes a few minor issues that I experienced when walking through the development setup instructions for Primero on WSL/Ubuntu:

  • Remove orphan docker run container.
  • Make need for directory change after docker setup explicit.
  • A typo in the curl command to install RVM.
  • The libpq APT package is now called libpq-dev.
  • Exception in database creation scripts unless the logs directory exists.
  • Ensure puma is served on localhost so that it's accessible on Windows/WSL.
@c-w c-w force-pushed the c-w:fix-setup-instructions branch from 5d80cd3 to cbb1bd7 Dec 19, 2019
@@ -65,7 +65,7 @@ On MacOS:

On Ubuntu:

$ sudo apt-get install -y libpq imagemagick
$ sudo apt-get install -y libpq-dev imagemagick

This comment has been minimized.

Copy link
@KSLHacks

KSLHacks Dec 19, 2019

Ran into this issue as well as it's a dependency for gem install pg. 👍

@c-w c-w force-pushed the c-w:fix-setup-instructions branch from cbb1bd7 to 8c2a14b Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.