Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup instructions #19

Closed
wants to merge 1 commit into from
Closed

Fix setup instructions #19

wants to merge 1 commit into from

Conversation

c-w
Copy link

@c-w c-w commented Dec 19, 2019 •
edited
Loading

This pull request fixes a few minor issues that I experienced when walking through the development setup instructions for Primero on WSL/Ubuntu:

  • Remove orphan docker run container.
  • Make need for directory change after docker setup explicit.
  • A typo in the curl command to install RVM.
  • The libpq APT package is now called libpq-dev.
  • Exception in database creation scripts unless the logs directory exists.
  • Ensure puma is served on localhost so that it's accessible on Windows/WSL.

kevinleung23
kevinleung23 reviewed Dec 19, 2019
View reviewed changes
README.md
@@ -65,7 +65,7 @@ On MacOS:

On Ubuntu:

$ sudo apt-get install -y libpq imagemagick
$ sudo apt-get install -y libpq-dev imagemagick
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this issue as well as it's a dependency for gem install pg. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinleung23 kevinleung23 kevinleung23 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-w @kevinleung23 @pnabutovsky