Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type error on named export #223

Merged
merged 2 commits into from
May 11, 2020
Merged

fix type error on named export #223

merged 2 commits into from
May 11, 2020

Conversation

gfmio
Copy link
Contributor

@gfmio gfmio commented May 11, 2020

This PR fixes the type error reported in #219 and #222.

@gfmio
Copy link
Contributor Author

gfmio commented May 11, 2020

@lpinca Here's the fix

@gfmio
Copy link
Contributor Author

gfmio commented May 11, 2020

@lpinca Apparently, the CI config is broken. I'm also checking what's up with #222

@lpinca
Copy link
Member

lpinca commented May 11, 2020

Browser tests do not run from PRs don't worry about that.

@gfmio
Copy link
Contributor Author

gfmio commented May 11, 2020

@lpinca For some reason my last commit didn't get pushed, so the PR should either be reverted or I need to create a new PR with the last commit.

@lpinca
Copy link
Member

lpinca commented May 11, 2020

Which one? cd071a7? If so it has been squashed.

@gfmio
Copy link
Contributor Author

gfmio commented May 11, 2020

Yes, cd071a7

@lpinca
Copy link
Member

lpinca commented May 11, 2020

It's there, sqashed.

@gfmio
Copy link
Contributor Author

gfmio commented May 11, 2020

@lpinca Here are the other changes this PR missed. #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants